This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Isaicp 4392: Change the 'Cancel account' button label on the user cancel form #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idimopoulos
force-pushed
the
ISAICP-4392
branch
2 times, most recently
from
adb089f to
228767c
Compare
…er cancellation forms.
…utton if access should not be granted.
…the url directly.
pfrenssen
reviewed
Jun 6, 2018
| @@ -65,6 +65,9 @@ public function buildForm(array $form, FormStateInterface $form_state) { | |||
| $collections = $this->relationManager->getCollectionsWhereSoleOwner($this->entity); | |||
|
|
|||
| if (!empty($collections)) { | |||
| // No access to the 'Cancel' button should be given if the user is the | |||
| // sole owner of a collection. | |||
| $form['actions']['submit']['#access'] = FALSE; | |||
There was a problem hiding this comment.
I agree with this but shouldn't we solve this differently? I would suggest to show a greyed out version of the button with a tooltip "This user cannot be deleted since it is the owner of a collection".
This is out of scope for this ticket so I made a followup for it: ISAICP-4555
pfrenssen
approved these changes
Jun 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.